feat(share/store_v2) Update file interface to use shwap types #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swap rowCol idx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3424 +/- ##
========================================
Coverage ? 43.22%
========================================
Files ? 285
Lines ? 16473
Branches ? 0
========================================
Hits ? 7120
Misses ? 8514
Partials ? 839 ☔ View full report in Codecov by Sentry. |
walldiss
changed the title
# Conflicts: # share/share.go # share/shwap/namespaced_data.go # share/shwap/row.go
walldiss
force-pushed
the
update-file-interface
branch
from
fc27652 to
7d3f5a7
Compare
walldiss
force-pushed
the
update-file-interface
branch
from
ceb8b87 to
9c6fba5
Compare
|
Superseeded by #3441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3423